Remove redundant preferredProvider variable in ProviderCommandReactor#1156
Draft
cursor[bot] wants to merge 1 commit intocodething/648ca884-claudefrom
Draft
Conversation
…Provider Co-authored-by: Julius Marminge <juliusmarminge@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the redundant
preferredProvidervariable inProviderCommandReactor.tsthat always equalsthreadProvider.Details
threadProvideris defined ascurrentProvider ?? inferProviderForModel(thread.model). The subsequentpreferredProviderwas defined ascurrentProvider ?? threadProvider, which collapses tothreadProviderin all cases:currentProvideris defined:threadProvider === currentProvider, so both resolve tocurrentProvider.currentProvideris undefined: the??falls through, sopreferredProvider === threadProvider.The fix removes the
preferredProviderdeclaration and replaces its two usages withthreadProvider.Note
Remove redundant
preferredProvidervariable inProviderCommandReactorRemoves the intermediate
preferredProvidervariable inProviderCommandReactor.tsand usesthreadProviderdirectly instartProviderSession. Behavioral Change: sessions started without an explicit provider now default tothreadProviderinstead ofcurrentProvider ?? threadProvider.Macroscope summarized 7b50561.